[13.1.X] Add SiPixelRawDataError monitoring for gpuValidation setup
#41938
Conversation
- add comparison histograms - add warning messages, add total FED errors hisogram, add comments on input parametets - add 2D map of GPU/CPU error unbalance vs FEDid / FEDerror type
…onventions in this package
…the gpuValidation modifier is run
|
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f509/33118/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
backport of #41920
PR description:
Somewhat inspired by the discussion at #41715 (comment), the main goal of this PR is to add a
DQMEDAnalyzer(SiPixelPhase1RawDataErrorComparator) designed to monitor the difference in terms of SiPixel Raw data errors in the CPU and GPU branches of the workflows running thegpuValidationmodifier.As there is no SoA-like data structure used in the CPU workflow (it reads directly the legacy digis) at variance with other heterogeneous data products used in the pixel workflow (recHits, tracks, vertices) I designed the module in order to read the legacy data format
SiPixelRawDataError(converted from SoA in the GPU workflow and run directly in the CPU one).I profit of this PR to fix a couple of bugs left from the portable data migration PR:
SiPixelCompareRecHitsSoA(commit d65a81a)SiPixelCompareRecHitsSoAthe convention Host -> CPU and Device -> GPU as used in other plugins of this packagePR validation:
Successfully run the worfklow
runTheMatrix.py -l 10824.507 --command='-n 100'.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim intermediate backport #41920 to 13.1.X to be proposed in the 2023 HLT menus.